Automattic / Automattic/harper

flag march and may when used as month and not verb

Open
#537 3 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

This follows a comment of @mrfragger on an issue I opened

> march is a tough one...as it's hard to tell if it's a verb...so should be excluded from checking. Same problem I had for bible names Mark... mark as a verb.
>
> My thinking is that ones like "march" and "may" will probably need dedicated lints involving heuristics based on the words in their context.

_Originally posted by @hippietrail in [#458](https://github.com/Automattic/harper/issues/458#issuecomment-2620831462)_

I hesitated in:
- reopening #458
- adding something to #461, but then the scope would have been different
- opening a new issue or completing

I chose the last option

Contributor guide

Open the contributing guide

Research direction

Start by reading the linked discussion in #458 and comparing the scope of #461; the issue names no files, tests, or entry points. Identify the existing lint structure and context-handling tests before deciding how month-versus-verb cases should be recognized. Done means march and may are flagged only in month usage, with coverage for the relevant contexts.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.