Automattic / Automattic/harper

feat: Flag present tense or past tense forms used where past participle is correct

Open
#485 3 comments 0 reactions 1 assignee Claimed by @hippietrail View on GitHub
enhancement harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

Most English verbs have the same form in past tense and past participle, but many do not. Past participles are used in making compound tenses like the present perfect and past perfect, in forming passives, and are often used as adjectives. The compound tenses may be easier to find as they follow `have` and `had` or their contractions `'ve` and `'d`, but possibly with intervening words such as an adverb or adverbial phrase.

One that has recently become common is using "lead" as the past of "to lead" instead of "led".

- This has **lead** to many mistakes → This has **led** to many mistakes

Here's some I'm finding in the wild:
- I **'ve** already **ran** into a snag on my desktop Linux test. → I **'ve** already **run** into a snag on my desktop Linux test.
- In the past this **lead** to wasteful military spending → In the past this **led** to wasteful military spending
- So a lack of competition **lead** to stagnation.
- I was **lead** to incorrectly believe that Argentina had always been a protectionist country with nationalised businesses this entire time.
- IBM dropping this after latest Anthropic announcement which **lead** to a drop in IBM stocks is hilarious
- due to complications with the Cygnus developed DMX library (which **lead** to the Linux version being selected for release)
- I ended up using perf in production, which indirectly **lead** me to understand the data race.
- Ulala's model has a low polygon count, which **lead** to her sex appeal being defined through her movement according to Mizuguchi.
- This **Lead** To The Sterile Cockpit Rule: Eastern Airlines 212 | Fascinating Horror

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.