Automattic / Automattic/harper

`MissingPreposition` triggered wrongly for "However, explorer does more work that just icon layout."

Open
#4,367 0 comments 0 reactions 0 assignees View on GitHub
bug false-positive harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

Image

> However, explorer does more work that just icon layout. If some of its tasks are O(n) – linear – then they will diffuse the impact of the O(n^2) tasks. As ‘n’ increases the O(n^2) tasks will eventually dominate, but I didn’t want my test harness to run even longer than the 160 seconds it was already taking.

This is true with a build of HEAD post version 2.10.0

Contributor guide

Open the contributing guide

Research direction

Start by locating the MissingPreposition rule and reproduce the warning on the quoted sentence using a current HEAD build. Trace why "that just" is flagged, then add a regression test for this text and confirm the warning no longer appears while the intended preposition cases remain covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.