Automattic / Automattic/harper

"advices" is flagged by `SplitWords` instead of by `MassPlurals`

Open
#4,346 0 comments 0 reactions 0 assignees View on GitHub
bug grammar linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

"advices" is a common mistake made by nonnative speakers who have no intuition of mass vs count nouns.

We have a linter, `MassPlurals` that deals with this but instead of flagging this error, another linter, `SplitWords` suggests splitting it into "adv" + "ices" or "ad + vices":

Image

Contributor guide

Open the contributing guide

Research direction

Start by reading the `MassPlurals` and `SplitWords` linter implementations and tracing how they classify “advices.” Reproduce the reported suggestions, then verify that `MassPlurals` flags “advices” while `SplitWords` no longer suggests splitting it.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.