Automattic / Automattic/harper

feat: Flag using a plural noun as a modifier for another noun

Open
#433 4 comments 0 reactions 1 assignee Claimed by @hippietrail View on GitHub
enhancement grammar harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

This is very common in non-native English but I've started seeing in younger native English speakers' writing sometimes. Also there are cases where it's not an error
- Incorrect stack **variables detection** and usage on x86 → ... variable detection ...

When it is fine it's often acceptable as both singular and plural:
- There was a huge **drug bust** in San Diego.
- There was a huge **drugs bust** in San Diego.

In other cases, the plural qualifier is used to disambiguate from another sense if the singular qualifier were used instead. I'll add some examples when I spot some in the wild.

I'll start compiling a list of exceptions to the rule here as I encounter them in the wild:
- finals spot
- finals win

And here I'll make a list of instances of this mistake I spot in the wild:
- High-Resolution 3D **Assets** Generation → **Asset** Generation
- SATA uses the same basic ATA and ATAPI **commands** sets → **command** sets
- their **summits** certificates were cancelled → their **summit** certificates were cancelled
- A **shoes** company. A hotel. → A **shoe** company. A hotel.
- Add **controllers** support → Add **controller** support
- ... is a unified view for visualizing the **events** history for a file. → ... is a unified view for visualizing the **event** history for a file.
- i have to mess with tyhe **colours** scheme → i have to mess with tyhe **colour** scheme
- for Windows devs to troubleshoot dll load **dependencies** issues.→ ... dll load **dependency** issues.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.