Automattic / Automattic/harper

Need to flag redundant "that" in "it seemed like that she ..." etc.

Open
#4,309 0 comments 0 reactions 0 assignees View on GitHub
enhancement grammar harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

From a YouTube video I'm watching:

> **It seemed like that** she was no longer kind of even remotely trying to lean into the joke.

There are probably other verbs in this pattern. Maybe "look like" and other sense verbs. It's only a mistake when "that" introduces a clause and not when it's a pronoun on its own.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the quoted sentence and inspecting existing grammar rules and tests for clause-introducing "that". Done means the checker flags the quoted construction without flagging standalone pronoun uses, with coverage for any additional patterns confirmed in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.