Automattic / Automattic/harper

Need to flag singular countable nouns used without a determiner.

Open
#4,292 1 comment 0 reactions 0 assignees View on GitHub
enhancement grammar harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

Image

> A month ago, especially smaller **model** would fall into a rabbit hole it dug for itself and would never recover.

should be

> A month ago, especially smaller **models** would fall into a rabbit hole it dug for itself and would never recover.

or

> A month ago, **especially a smaller model** would fall into a rabbit hole it dug for itself and would never recover.

(Adding "the", "this", "that", "my", etc. would also make it grammatical.)

This is a common mistake made by native speakers of Slavic languages and many Asian languages.

Contributor guide

Open the contributing guide

Research direction

Use the two quoted sentences as acceptance examples, along with the listed alternatives using a plural noun or determiner. Find the grammar-checking rule entry point and its existing tests, then verify that singular countable nouns without determiners are flagged while the grammatical alternatives are accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.