Automattic / Automattic/harper

Flag: using "whether" in a sentence with "or not"

Open
#424 10 comments 0 reactions 0 assignees View on GitHub
enhancement harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

`whether` implies the alternative, so writing this is invalid

| Invalid | Valid |
|---------|------|
| I wonder whether the water is cold or not| I wonder whether the water is cold|
| | I wonder if the water is cold or not|

Contributor guide

Open the contributing guide

Research direction

No files or tests are named in the issue. Start by locating the existing grammar-rule implementations and their tests, then add coverage for the invalid and valid sentence forms shown; done means the invalid form is flagged while both valid alternatives remain accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.