Automattic / Automattic/harper

False positive: "one" as a pronoun before mass noun

Open
#3,819 0 comments 1 reaction 0 assignees View on GitHub
bug false-positive grammar harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 12h
Merged PRs (30d)
106

Description

**What got flagged?**
> That way, we can keep the rankings and the questions separated without worrying about the scaling of one affecting the other.

**Why is this incorrect?**
In this sentence, "one" is used as a pronoun, rather than a count. As such, "affecting" being a mass noun is irrelevant to its usage.

**Example of correct usage:**
The above sentence should not be flagged.

Contributor guide

Open the contributing guide

Research direction

The issue names no file or test. Start by reproducing the reported sentence in Harper and trace the grammar rule that flags “one” before a mass noun. Add a regression case showing this pronoun usage is not flagged, then run the relevant grammar-checker tests to confirm the example remains clean.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.