Automattic / Automattic/harper

Flag and fix "as though that"

Open
#3,816 0 comments 0 reactions 0 assignees View on GitHub
enhancement harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

I heard this for the first time in a YouTube video and found more examples by Googling:

Genuine mistakes (relative pronoun) to flag and fix:
- A function type whose return value is void is treated **as though that** void were unknown
- It appears **as though that** this use of the the logging module (to create and save data to a file) had worked in the past but no longer does.
- It seems **as though that** i18n does not recognize my attribute so it defaults to replacing the innerHTML of the element
- but as an end user it appears **as though that** the command just has a readonly alias array
- It seems **as though that** trying this, when I try to multiply the 'payRunner' by the multiplier, it gets stuck at a decimal number far below
- It looks **as though that** when the seed is crafted in the refined storage system, it does not apply metadata
- It seems **as though that** you have used up all your inodes on your hosting plan
- The reality of this seems **as though that** if I dont want `[2]` to appear again when user presses back button on `[3]`, I must not call `addToBackStack` in the transaction that shows fragment `[3]`.
- Sorry if i'm not descriptive enough, I feel **as though that** I am pretty bad at explaining things but tried my best
- I fear **as though that** the series is quickly fading out of the public consciousness
- Do you ever feel **as though that** there's much more to life than what you see?
- Have you felt **as though that** games have been written by the same exact people for the past few years?
- I feel **as though that** when I completely clear my throat (through coughing) I sing way better.
- I guess I mean it's **as though that** I seem to really notice the effect while I'm doing things
- Do ancient stonebuilders, like Sumerians, talk about their building projects **as though that** have no precedent?
- I feel **as though that** we as a community must now Refer to the New awakened Mono as Raiden Mono.
- Well it's not **as though that** smells would make Hasu this wild
- It's **as though that** Henderson has memorized virtually the whole Bible and it is at his fingertips.
- We don't feel **as though that** impending doom is personal but rather a collective doom

Avoid flagging these (demonstrative) potential false positives:
- I feel **as though that** world model strongly correlates with memory
- The author declares that "software composability" is the solution **as though that** is a given fact.
- repeatedly citing screenshots of C# and Java code, **as though that** were somehow relevant in any way
- However, I feel **as though that** is a terrible idea.
- it seemed **as though that** was a pretty integral part required for training
- These people also use Kleenex as the plural, **as though that** somehow made sense.

Avoid flagging because there's a different error occurring:
- I feel **as though that** would more accurate. (missing 'be'?)

Contributor guide

Open the contributing guide

Research direction

No file, test, or entry point is named. Start by locating the grammar-checking rule that handles “as though” constructions and compare its behavior with the genuine mistakes, demonstrative false positives, and excluded missing-“be” example. Done means the intended cases are flagged and fixed while all listed exceptions remain unflagged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.