Automattic / Automattic/harper

"Complement well with" & "clash well"

Open
#3,806 0 comments 0 reactions 0 assignees View on GitHub
enhancement harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 12h
Merged PRs (30d)
106

Description

I found these two mistakes separately a day or two apart but they seem very similar. They could be handled in either one linter or two.

**"Complement well with"** is redundant and **"Clash well"** is an oxymoron, but people use them in the same way.

They both seem to be used to say that things go together, suit each other, fit, etc.

The **"Clash"** version allows the possibility that the writer may mean they match or may mean they clash. Perhaps only one mistake occurs and perhaps only context and semantics can clarify which is meant.

**Clash well:**
- Some people just don't clash well with other people or they simply bring out the worst in each other.
- ... which, surprisingly, clash well
- The dessert - flavor didn't really clash well.
- The purple and blue doesn't clash well, but it's a nice simple piece of art.
- BFB Grass and BFDIA grass don't clash well
- Underleveled identities can't clash well due to offensive levels so if you struggle, ...
- I can't clash well with her at all.
- Though an easy and non controversial character would be Yukiko and her development that doesn't clash well with western ideals
- In fact you should especially clash with the greens ones since verg doesn't clash well with those and one of them halves hurting stacks ...
- never going to see the light of day as they just don't clash well enough
- If ego doesn't clash well,unopposed ego so that you'll at least have a passive for the battle.
- its very frustrating cuz a lot of my sinners don't clash well cuz their offense level was too low for that high of a floor.

**Complement well with:**
- This sauce complements well with grilled chicken.
- The wine complements well with the cheese, enhancing the overall dining experience.
- Does Sprint 0 complements well with Scrum?
- What Complements well with VSL?
- My jungler should pick a champion that complements well with the mid-lane Jax.
- I hope he complements well with JT and the rest.
- A beautiful display of earthy colours complementing well with the crisp colours of nature.
- Since yall loving the first one, here are the 5 colors that complement well with Blush or Dusty Pink
- WIFI fingerprinting positioning complements well with GNSS-based positioning in that although there is limited satellite view in urban environment
- POKKA's Oolong Tea complements well with your meal!
- How To Pick The Perfect Rug To Complement Well With Your Dark Wood Floor?
- Best-selling luxe velvet pillows complement well with coordinating design pieces for a chic decor collection
- Here are the 5 colors that complement well with Yellow
- Initial plan is also being put in place to investigate hydrogen and fuel cell technologies that would complement well with the hydropower generation

Contributor guide

Open the contributing guide

Research direction

The issue does not name files, tests, or entry points. Review the existing linter checks and the examples for “clash well” and “complement well with” to decide whether one or two checks fit; done means the intended misuse is detected while the semantic ambiguity is handled without broad false positives.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.