Automattic / Automattic/harper

False positive flagging "there" to change to "their"

Open
#3,700 0 comments 0 reactions 0 assignees View on GitHub
bug false-positive harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

Image

> While I was in there testing ...

`ThereToTheir` is surely seeing that the next word qualifies as a noun (gerund) but in this case it's probably more of a verb (present participle) but the key is likely to be that "in there" is already idiomatically a unit, which might be the way to early-exit the heuristic tests?

Contributor guide

Open the contributing guide

Research direction

Start with the `ThereToTheir` heuristic and reproduce the report using “While I was in there testing ...”. Trace why “in there” is treated as a correction candidate, then verify that the idiom remains unchanged while genuine there/their cases are still flagged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.