Automattic / Automattic/harper

False Flags: "you yourself", "out right", "fanfiction"

Open
#3,525 1 comment 1 reaction 0 assignees View on GitHub
bug harper-core linting spelling
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

### "You yourself"

**What got flagged?**
The text that was incorrectly flagged.
"Ever write something you yourself hate to think about?"
"Even you yourself must admit that is pretty silly." (oddly, it didn't flag it that time?)
Rule: PossessiveYour

**Why is this incorrect?**
The "you" is flagged. It is suggesting "your", "you're a", or "you're an", all of which would be incorrect.
It's similar to using a phrase like "he himself hated that". That isn't flagged – it is correct – but in the case of "you" here, it was flagged.

**Example of correct usage:**
"Ever write something you yourself have to think about?"

-------------------------

### "Out right" (TW: Blood/Injury due to the context being a horror fanfiction)

**What got flagged?**
(in a bullet point list of injuries)
"Deep cut down left arm, crudely stapled shut and poorly bandaged, just enough for him to not bleed out right away."
"out right" was flagged. It was just flagged again in the prior sentence saying it was flagged.
Rule: DisjointPrefixes

**Why is this incorrect?**
It suggested changing it to "outright", which would be incorrect in this case as it is followed by "right away" and is being used to indicate time.

**Example of correct usage:**
"I can't go out right away."
"The food ran out right away."

--------------------------

### Fanfiction

**What got flagged?**
Any time I write the word "fanfiction", it is flagged as a typo, with no option to just add it to my dictionary.

**Why is this incorrect?**
It claims it should be spelled "fan fiction" with a space, but no one I know of spells it that way when speaking of fanfiction such as that on AO3.

**Example of correct usage:**
"I have been writing fanfiction lately."
"I've read a lot of fanfiction."

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the three examples and inspect the implementations of the named PossessiveYour and DisjointPrefixes rules. Check how unknown words such as “fanfiction” are handled by the dictionary, then add coverage showing that these usages are not incorrectly flagged and run the relevant test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.