Automattic / Automattic/harper

False positive: `PronounKnew` flags "anyone new"

Open
#3,257 0 comments 0 reactions 0 assignees View on GitHub
bug harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

Image

> before inviting anyone new in.

This can probably be fixed by not flagging after so-called "indefinite pronouns". Those are currently not marked in the dictionary. Perhaps the same can be achieved by checking if the word before "new" is a "personal pronoun", which can currently be queried.

Contributor guide

Open the contributing guide

Research direction

Start by locating the PronounKnew rule and the dictionary entries it uses, then inspect how personal pronouns are queried. Reproduce the "anyone new" example and confirm that it is no longer flagged while the rule still catches its intended cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.