Automattic / Automattic/harper

False positive: "What do you think were the" -> "What do you think where the" (`WereWhere`)

Open Beginner friendly
#3,214 0 comments 1 reaction 0 assignees View on GitHub
bug harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 12h
Merged PRs (30d)
106

Description

**What got flagged?**
"What do you think **were** the…"

'were' corrected to 'where' by `WereWhere`

**Why is this incorrect?**
Here, `were` is the intended word.

In fact, even if 'where' was meant, it would be (at least in my opinion) a confusing use of grammar, and this should therefore be corrected the other way.

**Example of correct usage:**
```md
What do you think were the effects the olives had on the pasta's flavor?
```

Contributor guide

Open the contributing guide

Research direction

Search the Rust rule implementation and tests for the `WereWhere` entry point, then read how it handles “were” before a noun phrase. Add the supplied example as a regression case and verify that the intended wording is no longer flagged while valid “where” cases remain covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.