Automattic / Automattic/harper

False positive with `ThatThan` linter

Open
#3,209 0 comments 0 reactions 0 assignees View on GitHub
bug harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

Image

> It's even cooler that he got the passion from his Dad.

This is a context in which "that" can legitimately follow an adjective in the comparative form.

I'm not sure how to disambiguate the legit case from the error case as these snippets would all be legit:
- cooler than
- even cooler than
- cooler than he (than he is, than he thinks, etc.)
- It's even cooler than

It probably/possibly not possible to know it's a mistake until we get to where "got" has an object.

Contributor guide

Open the contributing guide

Research direction

Start by locating the ThatThan linter implementation and its existing tests. Reproduce the reported sentence and add coverage for the listed legitimate comparative forms; done means the valid cases are accepted without losing detection of the intended error cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.