Automattic / Automattic/harper
False positive in `OneOfTheSingular`
Open
bug
harper-core
linting
- Dominant language
- Rust
- Stars
- 15.4k
- Forks
- 627
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 106
Description
> Yours is one of the best I’ve found.
It must be due to "best" being considered a noun in the dictionary. Better look into how true that is. Maybe just special-casing "best" will be the right fix?
Contributor guide
Research direction
Start by locating the OneOfTheSingular rule and the dictionary logic it uses, then reproduce the reported sentence, “Yours is one of the best I’ve found.” Check why “best” is treated as a noun and add a regression test showing that this sentence is no longer flagged, while the rule still catches its intended cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100