Automattic / Automattic/harper

False positive: "for you tonight" flagged to change "you" to "your"

Open
#3,183 0 comments 1 reaction 0 assignees View on GitHub
bug grammar harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

Image

> We’re going to rock our asses off for you tonight, right after we set up the pitch correction and autotune

I'm guessing the `PossessiveYour` rule checks for the word after "you" being a noun but in this case "tonight" is used as an adverb.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reported sentence and inspect the PossessiveYour rule, which the issue identifies as the likely source of the false positive. Confirm that “for you tonight” is no longer flagged while possessive uses of “your” continue to be detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.