Automattic / Automattic/harper

False negative: "does not worked" is not flagged

Open
#3,177 0 comments 0 reactions 0 assignees View on GitHub
bug enhancement false-negative grammar
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

This sentence was used in a new Harper issue on GitHub:

Image

> Text Suggestion does not worked on Reddit

After "does" or "does not" the verb should be in its lemma form (base form, same as present tense form).

This is best addressed as part of a larger scope of verbs following other verbs. We may have another feature request or bug report that covers it or covers part of it. In particular "do" is an auxiliary verb, along with "have", "be", and the modal verbs such as "can", "must", etc.

There are some differences that need to be thought through though or experimented with:
- it does work ✅
- it doesn't work ✅
- does it work? ✅
- did it work? ✅
- it did work ✅
- do it work? ❌
- it do work ❌
- do they work ✅
- they do work ✅
- doing it work ❌ but there might be larger contexts where it works for some verbs/pronouns?
- done it work ❌ as above?

The same seem to be valid after the modal verbs but different after the other auxiliary verbs.
- After 'have', 'has', 'had' you use the past participle of the following verb and the results are present perfect, past perfect tenses.
- After "be" you get a passive form.

But I'm not 100% sure if there are other verbs that might fit the "do" pattern. Perhaps sense verbs like "see it work"?

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by locating the existing grammar rules and tests for verbs following auxiliary or modal verbs, then reproduce the reported sentence and compare it with the listed valid and invalid examples. Done means the intended forms are flagged without regressing the accepted examples, with the broader verb scope resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.