Automattic / Automattic/harper

False positive in `ItsPossessive` rule

Open
#3,035 0 comments 0 reactions 0 assignees View on GitHub
bug harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 12h
Merged PRs (30d)
106

Description

Image

> .. laying around decides **it's time** to have some explosive, psychotic fun.

In this case it's clear that ***it's*** is the correct choice already as it means ***it is***.

The more I look at this one the more I think it will be quite hard to distinguish perfectly. You can imagine a sentence like:
- The bot decides **its** time is still not fast enough.
or even
- The AI decides **its** time to launch a thread is too long.

But from Googling for usage examples I only found mistakes for ***it's*** in the first few pages of results.

Contributor guide

Open the contributing guide

Research direction

Start by locating the `ItsPossessive` rule and reproduce the reported “it's time” sentence alongside the two contrasting examples in this issue. Review the rule's existing tests, if present, and verify that the false positive is removed without losing detection of possessive `its` usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.