Automattic / Automattic/harper
False Positives: The form of the verb must agree in grammatical number with the pronoun
- Dominant language
- Rust
- Stars
- 15.4k
- Forks
- 627
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 106
Description
**What got flagged?**
>She motioned to the glass.
>When had he become such a curmudgeon?
>She spun around on her stool as he tried to piece together a response.
**Why is this incorrect?**
These three sentences are grammatically correct.
These three sentences produce the `PronounVerbAgreemet` error.
The first, highlighting _motioned_, offers no suggested solution. It's unclear what it finds wrong here. It is similar to the third, which highlights _spun_. Both of these sentences refer to a singular _she_, but appear to think motioned and spun are either plural and shouldn't be, or need to be? Is it struggling with the past-tense forms of these words?
The second highlights _become_, offering the quick fix of _become**s**_ which is a puzzling suggestion and unquestionably wrong.
Contributor guide
Research direction
Start by reproducing the three reported sentences and inspecting the PronounVerbAgreemet diagnostic and suggested fixes. Trace the rule that handles past-tense verbs and modal or auxiliary constructions; done means these grammatical sentences produce no false positives or incorrect corrections, with regression coverage for the examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100