Automattic / Automattic/harper

False positive: ItsContraction "does its best"

Open
#2,548 1 comment 0 reactions 0 assignees View on GitHub
bug harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

**What got flagged?**
```
╭─[todoist.markdown:1:1]

111 │ Home Assistant does its best to [determine what task in each project is "most" important](https://github.com/home-assistant/home-assistant/blob/master/homeassistant/components/todoist/calendar.py), and it's that task which has its state reported. You can access the other tasks you have due soon via the `all_tasks` array (see below).
│ ─┬─
│ ╰─── [Punctuation::ItsContraction] (pri 54): Use `it's` (short for `it has` or `it is`) here, not the possessive `its`.
─────╯
```

https://github.com/home-assistant/home-assistant.io/blob/f1c8b9b2b1a5368f002717d9c911876532078517/source/_integrations/todoist.markdown?plain=1#L111

**Why is this incorrect?**

This is possessive.

**Example of correct usage:**
N/A

Contributor guide

Open the contributing guide

Research direction

Start by locating the ItsContraction rule in the Harper source and reviewing how it handles possessive "its" versus "it's". Use the linked todoist.markdown example as the reproduction case; done means this sentence is no longer flagged while genuine contraction errors remain detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.