Automattic / Automattic/harper

False positive: ItsContraction "with its built-in LED"

Open
#2,545 1 comment 0 reactions 0 assignees View on GitHub
bug harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

**What got flagged?**
```
mystrom.markdown: 1 lints
Advice:
╭─[mystrom.markdown:1:1]

82 │ The buttons will give you feedback with its built-in LED:
│ ─┬─
│ ╰─── [Punctuation::ItsContraction] (pri 54): Use `it's` (short for `it has` or `it is`) here, not the possessive `its`.
────╯
```

https://github.com/home-assistant/home-assistant.io/blob/f1c8b9b2b1a5368f002717d9c911876532078517/source/_integrations/mystrom.markdown?plain=1#L82

**Why is this incorrect?**

I suppose the sentence might not that great English, but possessive "its" is correct here.

**Example of correct usage:**

N/A

Contributor guide

Open the contributing guide

Research direction

Reproduce the lint on the sentence in source/_integrations/mystrom.markdown at the linked line, then trace the Punctuation::ItsContraction rule that flags it. Confirm the possessive usage and add a regression check so this sentence is no longer reported while genuine its/it's errors remain detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.