Automattic / Automattic/harper

Incorrectly flagging "de facto"

Open
#1,960 2 comments 0 reactions 0 assignees View on GitHub
bug harper-core linting spelling
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

**What got flagged?**
Any sentence containing "de facto" or "de-facto".
See the examples for concrete sentences.

**Why is this incorrect?**
It's a common phrase used instead of "in practice".
See the [wiki article](https://en.wikipedia.org/wiki/De_facto) for reference.

**Example of correct usage:**
You can find a lot of example usage in practice.
See [github search "de facto"](https://github.com/search?q=%22de+facto%22&type=code)
or [github search "de-facto"](https://github.com/search?q=%22de-facto%22&type=code)

- [Or is it a de facto part of the Steinmetz diamond empire?](https://github.com/ANCIR/PanamaPapers/blob/8f1117fdf5baeb8522e6172574219720d17086c5/guinea.md?plain=1#L43)
- [The de-facto solution to flexible routing with nested views in AngularJS](https://github.com/angular-ui/ui-router)

Contributor guide

Open the contributing guide

Research direction

Search the grammar-checking rules for the patterns "de facto" and "de-facto", then reproduce the report using the sentences linked in the issue. Update the relevant rule so these common phrases are not flagged, and run the existing rule tests or checker test suite to confirm both spellings remain accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.