Automattic / Automattic/harper

`ExpandMemoryShorthands` should often use singular

Open
#1,862 1 comment 0 reactions 0 assignees View on GitHub
bug grammar linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

**Describe the bug**
In very common contexts the abbreviations don't reflect whether the full term would correctly be singular or plural. It turns out singular is very commonly what's needed: Image

Those should be "mebibyte" and "kibibyte" respectively.

**Expected behavior**

If it's part of a qualifier it should be singular. (Also if the number is exactly `1` or `one`.)

Contributor guide

Open the contributing guide

Research direction

Locate `ExpandMemoryShorthands` in the Rust codebase and inspect how it expands abbreviations in qualifiers and numeric contexts. Add coverage for singular forms such as “mebibyte” and “kibibyte,” including exactly `1` or `one`, and run the relevant existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.