Automattic / Automattic/harper

Incorrect suggestions after applying fix for `WiFi -> Wi-Fi`

Open
#1,450 6 comments 3 reactions 0 assignees View on GitHub
bug good first issue harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

## Description

When I write the sentence "The WiFi at the office was slow today." on writewithharper.com I get the suggestion to replace `WiFi` with `Wi-Fi` which seems fine, but then it starts flagging `Wi` as a typo and the `Fi at` as a potential misspelling of `Fiat` which are both false positives in that context.

## Resources

Wi-Fi appears to be the [correct way of writing this](https://en.wikipedia.org/wiki/Wi-Fi) so I don't know what Harper could do here but it sure is annoying

## Screenshots

Initial sentence

![Image](https://github.com/user-attachments/assets/6e62a20a-a540-4b75-a39d-786d6b9d1259)


Incorrect suggestions after the edit is applied

![Image](https://github.com/user-attachments/assets/70e4b0a8-2e05-4b64-a529-49e618b2254b)


Contributor guide

Open the contributing guide

Research direction

Start by reproducing the sentence on writewithharper.com and compare the initial suggestions with the results after applying WiFi → Wi-Fi. Trace the Rust checker’s replacement and subsequent tokenization or spell-checking behavior, then add a regression test for this sentence if the relevant test area is found. Done means Wi-Fi is accepted without separate false positives for Wi or Fi at.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.