Automattic / Automattic/harper

Obsidian plugin - Harper does not respect 'off' option for long sentences & spell check options

Open
#1,376 5 comments 0 reactions 0 assignees View on GitHub
bug config-options-prefs-settings obsidian-plugin
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

When I set the 'Long Sentences' and/or the 'Spell Check' options to 'Off' in the Obsidian plugin's configuration page, Harper does not disable these checks - long sentences & incorrect spelling are still flagged (see screenshots below)

Spelling error text:

`Lorem ipsum dolor sit amet, consectetur adipiscing elit Integer faucibus purus vitae est viverra ornare. Donec semper, purus id eleifend cursus, nisl diam malesuada tortor, in elementum velit arcu sit amet nibh Nunc lacinia ac tortor euismod pharetra. Aenean iaculis pellentesque quam vel molestie. Aenean vel enim eget nulla viverra placerat. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque ultrices est enim, ac dapibus leo bibendum in Proin fermentum, enim vel vestibulum finibus, leo metus pulvinar dia sit amet aliquet ex dolor ac orci Morbi turpis ante, rhoncus ut sodales eu, vulputate ornare enim. Cras imperdiet ipsum vitae tempus consectetur. Curabitur interdum vulputate lectus Mauris dignissim ligula id libero finibus interdum. Fusce dictum mi a est lacinia, eget tempus turpis tristique Mauris tristique, quam sed ultricies tempor, eros sapien blandit risus, eu pellentesque ligula ante semper purus Ut vulputate fermentum velit, eget rhoncus lacus rutrum in.`

Long sentence text

`There are many variations of passages of Lorem Ipsum available, but the majority have suffered alteration in some form, by injected humour, or randomised words which don't look even slightly believable If you are going to use a passage of Lorem Ipsum, you need to be sure there isn't anything embarrassing hidden in the middle of text All the Lorem Ipsum generators on the Internet tend to repeat predefined chunks as necessary, making this the first true generator on the Internet. It uses a dictionary of over 200 Latin words, combined with a handful of model sentence structures, to generate Lorem Ipsum which looks reasonable The generated Lorem Ipsum is therefore always free from repetition, injected humour, or non-characteristic words etc.`

**To Reproduce**

Using the Obsidian plugin:

1. Type out text that includes spelling errors and excessively long sentences
2. Disable 'Spell Check' and 'Long Sentences' options in the settings
3. Observe that Harper still reports these

**Expected behavior**
Harper to ignore these errors

**Screenshots**

![Image](https://github.com/user-attachments/assets/41e6515c-5a70-43d2-bb00-081c827d60f5)

![Image](https://github.com/user-attachments/assets/35396477-79d6-40fb-8cd3-b92c6bf2f8b1)

![Image](https://github.com/user-attachments/assets/7a5f900f-81bd-4327-b65d-3345e09685eb)

**Platform**
Obsidian

**Additional context**
Both rules have 'undefined' in their descriptions - not sure if that's connected. Did not have the opportunity to test the 'Wrong Quotes' option which has the same, as I don't know what actually triggers that.
Restarting Obsidian, disabling and enabling the plugin, and changing the settings to On and back to Off did not resolve the issue

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in the Obsidian plugin with Spell Check and Long Sentences disabled, then trace the plugin's configuration handling for those options. Done means both checks are suppressed when set to Off, including after restarting or toggling the plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.