Automattic / Automattic/harper

Rule "Overall" false positive: "Iterate over all"

Open
#1,249 0 comments 3 reactions 0 assignees View on GitHub
bug good first issue harper-core linting
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
102

Description

## Description

I have this comment:
```lua
-- Iterate over all the save data in the slot.
```
Harper Suggestion: "Did you mean the closed compound `overall`?" Which is incorrect.

It flagged a non-error and suggested an incorrect fix.

I thought adding 'of' might make it more explicitly correct:

```lua
-- Iterate over all of the save data in the slot.
```

But instead it added another suggestion: "Consider simplifying to `all the`."

Provide a detailed description of the false positive flagged by Harper.

It accepts removing "all" but the comment is trying to emphasize that this function includes **all** data whereas other functions are only partial:

```lua
-- Iterate over the save data in the slot.
```

Contributor guide

Open the contributing guide

Research direction

Reproduce the false positive with the Lua comments shown in the issue, focusing on the rule named "Overall" and its suggestions for "all" and "all of the." Trace where that rule evaluates these phrases, then verify that the intended emphasis on all save data is no longer flagged while genuine closed-compound cases remain detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.