Automattic / Automattic/harper

bug: Sentence parser does not include final quotation mark

Open
#1 1 comment 1 reaction 1 assignee Claimed by @elijah-potter View on GitHub
bug harper-core punctuation
Dominant language
Rust
Stars
15.4k
Forks
627
Avg merge
1d 15h
Merged PRs (30d)
106

Description

The current sentence implementation does not consider that quotation marks can appear _after_ the sentence terminator. We should consider this final quotation as part of the sentence.

For example:

```
She said, "There is no way this is true."
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.