Automattic / Automattic/expect.js

Set comparison with eql is wrong

Open
#143 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.1k
Forks
207
PR merge metrics
No merged PRs in 30d

Description

expect(new Set([1])).not.to.be.eql(new Set([2])); // fails

You get the following output:
Error: expected {} to sort of not equal {}
Expected :{}
Actual :{}

I can work on a PR for this.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the Set comparison example from the issue and locate the equality-comparison entry point used by eql. Add a regression test covering Sets with different values; done means the example passes and the test verifies that the Sets are not considered equal.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.