Automattic / Automattic/edit-flow

Name collision with get_post_status filter

Open
#905 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
366
Forks
137
Avg merge
2h 11m
Merged PRs (30d)
6

Description

Not sure if there's a backwards-compatible way to fix this, but I tracked down an error to the Edit Flow plugin's "post_status" taxonomy name triggering a call to `get_post_status` filters - but whereas I have a plugin that expects that to be the [core filter to be related post statuses](https://developer.wordpress.org/reference/hooks/get_post_status/), it's actually triggered by `get_{$taxonomy}` running on the Edit Flow taxonomy called `post_status`.

The practical fix is to get the other plugin to more carefully check what it's actually being passed, but I don't feel like I can entirely fault them for using the `get_post_status` filter as documented, either.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.