Automattic / Automattic/domain-services-client

`Domain\Suggestions` command fails when search term contains a trailing `.`

Open
#199 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
5
Forks
4
PR merge metrics
No merged PRs in 30d

Description

When users search for a domain name with a trailing `.` (e.g. `something.blog.`), the `Domain\Suggestions` command fails with the following error message:
>Could not get TLD of domain suggestion

This is probably an edge case, but there's a chance that a search may contain a typo. While we can strip out the trailing `.` client side, but ideally, the DSAPI should still proceed with the search in such cases, instead of erroring out.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the Domain\Suggestions command and the code path that produces “Could not get TLD of domain suggestion.” Reproduce the failure with `something.blog.`, then add or update coverage for the trailing-dot case; done means the search proceeds without that error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.