Automattic / Automattic/dangermattic

Improve message on Manifest lock changes check

Open
#65 0 comments 1 reaction 0 assignees View on GitHub
enhancement plugins
Dominant language
Ruby
Stars
10
Forks
2
PR merge metrics
No merged PRs in 30d

Description

The `Package.swift` changed warning wording can be misleading because, for a whole class of changes, it does not affect the `Package.resolved` content.

In the lack of smarter ways (without a lot more effort) to detect such cases, we could rephrase the message to something like:

> ⚠️ Package.swift was changed but its corresponding Package.resolved was not. Please ensure Package.resolved is up to date if any of the dependencies in Package.swift changed.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the check that emits the warning about Package.swift changing without a corresponding Package.resolved change, then review its current wording. Update the warning to acknowledge that some Package.swift changes do not affect resolved dependencies, and run the relevant project tests to confirm the message is correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, swift
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.