Automattic / Automattic/dangermattic
Better consider how modified_files vs. renamed_files work
Open
- Dominant language
- Ruby
- Stars
- 10
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Perhaps we may need to merge renamed / modified files in methods such as `all_changed_files`.
See https://github.com/Automattic/dangermattic/pull/9#discussion_r1314759134 and https://github.com/ashfurrow/danger-rubocop/pull/50
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the all_changed_files method and compare how modified_files and renamed_files are represented. Read the linked Danger discussions for the expected behavior, then identify the relevant tests or add coverage for the agreed handling. Done means the behavior for modified and renamed files is explicitly defined and verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100