Automattic / Automattic/dangermattic

Idea: List modified view files

Open
#28 1 comment 0 reactions 0 assignees View on GitHub
enhancement idea
Dominant language
Ruby
Stars
10
Forks
2
PR merge metrics
No merged PRs in 30d

Description

I just got this warning in https://github.com/wordpress-mobile/WordPress-iOS/pull/22000

image

(source: https://github.com/wordpress-mobile/WordPress-iOS/pull/22000#issuecomment-1809310967)

I wonder if it would be useful to list the view files that have been modified?

To prevent it becoming a visual mess when many files have been modified, we could cap the list to `n` items:

> View files have been modified, but no screenshot is included in the pull request. Consider adding some for clarity.
>
> Files: `AView.swift`, `AnotherView.swift`, `OneMoreView.swift`, plus 5 more.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start from the warning shown in WordPress-iOS pull request 22000 and locate the Danger plugin code that emits it. Check how modified files are identified, then add a capped list of modified view filenames with an overflow count; done means the warning remains readable and matches the proposed wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, swift
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.