Automattic / Automattic/block-experiments

Layout Grid: Rerender is closing the inline Inserter

Open
#294 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
JavaScript
Stars
131
Forks
18
PR merge metrics
No merged PRs in 30d

Description

This was discovered after the recent Gutenberg v14.2.0 upgrade (p1664214321796799/1664214321.580149-slack-CBTN58FTJ). Fortunately, it shouldn't affect many users because it requires a ⚡ fast click on the `+` button right after selecting the columns count. Such a speed is not an issue for the testing framework, though (Playwright), so for now, we needed to [manually pause the execution](https://github.com/Automattic/wp-calypso/blob/ed1ef6ad7c5c00cdee754d17bae854a13be943b0/packages/calypso-e2e/src/lib/blocks/block-flows/layout-grid.ts#L54-L61) to make the test pass, as there's nothing else we can hook on to (like an "is-loading" class or attribute change).

I'm attaching a repro video so it's clear what the bug looks like:

https://user-images.githubusercontent.com/1451471/194037156-29b76694-cc39-46de-aa98-a4aacfeec7f4.mov

/cc @fullofcaffeine @worldomonation

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.