Automattic / Automattic/batcache

Bad cookie default configuration disabling cache when not needed

Open
#106 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
295
Forks
102
PR merge metrics
No merged PRs in 30d

Description

there are common cookies that will disable batcache because there is bad default cookie configuration. Currently, all cookies that begin with wp will cause cache to bypass. But there are no wp cookies I am aware of that should disable cache. But there are cookies like wp_lang or wpl_* from wpeka gdpr plugin, that will cause batcache to not cache the page. I run into this issue in Pressable hosting sertvice, where they are using batcache for their distributed Edge Cache implementation, but there is no way to change configuration of it

I made pull request with my proposed changes in default behavior

https://github.com/Automattic/batcache/pull/105

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.