Automattic / Automattic/WP-Job-Manager

Job filters layout enforced to be on two rows

Open
#1,794 3 comments 0 reactions 0 assignees View on GitHub
[Type] Question
Dominant language
PHP
Stars
899
Forks
369
Avg merge
11h 37m
Merged PRs (30d)
12

Description

Hey,

I've noticed that in 1.33.0 the job-filters.php template got this line:

https://github.com/Automattic/WP-Job-Manager/blob/e9256aa03c9a7e9ad1c37fd186de81dbdc149038/templates/job-filters.php#L39

I understand where it comes from and that it was an easy decision here: https://github.com/Automattic/WP-Job-Manager/pull/1708 but not all the themes are using the filters or the Search button on a second row. For example, I have to overwrite the template just to remove this one line only to accomplish a layout like this:
![Screenshot 2019-06-12 at 19 17 53](https://user-images.githubusercontent.com/1893980/59368460-f3dbb480-8d46-11e9-9c97-18c55491ae96.png)

Maybe a padding-bottom, or a boolean based filter, would be more useful rather than resetting the entire float row.

Not a big issue, as I said, themes could overwrite the template, but maybe we can elegantly solve this, without the need of maintaining a template version for just one line.

Cheers

Contributor guide

Open the contributing guide

Research direction

Start with templates/job-filters.php at the referenced line and read pull request #1708 to understand why the two-row layout was introduced. Compare the current template behavior with themes that keep filters and the Search button on one row. Done means the layout is flexible without requiring users to maintain a copied template.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
frontend, web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.