Automattic / Automattic/VIP-Coding-Standards

Custom IniSet Sniff to allow for certain safelisted options

Open
#687 1 comment 0 reactions 0 assignees View on GitHub
Type: Enhancement
Dominant language
PHP
Stars
261
Forks
44
Avg merge
19m
Merged PRs (30d)
1

Description

## Describe the solution you'd like

VIPCS could benefit from having a custom IniSet sniff...similar to https://github.com/WordPress/WordPress-Coding-Standards/blob/41f5a9c66ff814863bc479fb52fd6cd1abc87e28/WordPress/Sniffs/PHP/IniSetSniff.php#L55-L65, but we want to be able to customize the whitelist property for the below values:

- session.cookie_httponly
- session.cookie_secure
- session.use_only_cookies

WP already manages sessions but we have some clients that want to control PHP sessions via custom code.

## What code should *not* be reported as a violation?

```
ini_set('session.cookie_httponly', true);
ini_set('session.cookie_secure', true);
ini_set('session.use_only_cookies', true);
```

## Additional context
https://github.com/WordPress/WordPress-Coding-Standards/issues/1993

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.