Automattic / Automattic/ScreenObject

Offer `static` version of `isLoaded`

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

While working on [this](https://github.com/Automattic/simplenote-ios/pull/1401) Simplenote iOS automation PR, I found myself implementing a `static` version of `isLoaded`. That's a functionality that we'll need in different screens across our projects, so it would be great to push it down to the `ScreenObject` base class.

One obstacle in the way is that, currently, the `init` method makes the tests fail if the element is not found. I think we should change this to simply throwing an error, or even not checking that the screen exists (maybe) to:

1. Allow a `static` `isLoaded` implementation that internally initializes and instance and calls its `isLoaded` instance property
2. Be less opinionated and let consumers deal with the screen not being available at init time

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.