Automattic / Automattic/AutomatticAbout-Swift

Invesigate disabling haptics when modals are presented

Open
#6 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Swift
Stars
8
Forks
4
PR merge metrics
No merged PRs in 30d

Description

In [this PR](https://github.com/Automattic/AutomatticAbout-Swift/pull/4) we disabled haptics when a submenu is pushed or when the app logos cell is offscreen. Unfortunately these changes dont have any effect when a modal is presented over the top of the About screen, as the `viewDidDisappear` / `viewWillAppear` methods aren't called.

We can investigate whether there's another way to fix this, for example through implementing the `UIAdaptivePresentationDelegate` methods and becoming the delegate of the presented view controller.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing PR #4 and the About screen lifecycle handling described in this issue. Investigate whether UIAdaptivePresentationDelegate methods can handle modal presentation and dismissal where viewDidDisappear/viewWillAppear do not run. Done means haptics remain disabled while a modal covers the About screen and resume appropriately afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.