Autodesk / Autodesk/standard-surface

Unused sheen default value?

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
CSS
Stars
348
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Hi! The spec describes a default value of 0.8 for the weight of the sheen BRDF:
https://autodesk.github.io/standard-surface/#closures/sheen

However, in the implementations, the value is actually set to 0.0:
https://github.com/Autodesk/standard-surface/blob/b34e081e0fdced603eaa87b1c2841f99986fde2e/reference/standard_surface.mtlx#L51
https://github.com/Autodesk/standard-surface/blob/b34e081e0fdced603eaa87b1c2841f99986fde2e/reference/standard_surface.osl#L177

Is this because the layer is optional and the input serves as both weight and toggle?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.