pipelineID is not resolved for existing pipeline when multiple pipeline stages are used
- Dominant language
- Go
- Stars
- 21
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
### Pre Requisites
* [x] Put an X between the brackets on this line if you have done all of the following:
* Checked the FAQs on the message board for common solutions:
* Checked that your issue isn't already filed:
### Description
While rendering a nested pipeline If one of the pipeline stage is a nested pipeline and another refers to an existing pipeline. The spinnaker pipeline id for the existing pipeline stage is not resolved. This is due to faulty check that skips the id resolution due to this check (https://github.com/Autodesk/shore/blob/567fcf51dd852d6449986a5de009e8dbebf09c8f/pkg/backend/spinnaker/backend.go#L751))
For example: In the nested pipeline in the image below (which is linked by the main application pipeline), the Redner stage refers to an existing pipeline while the Deploy stage that follows it is a nested pipeline. In the second image you can see that shore did not resolve the id of the Render pipeline (which was set to null).
Pipeline line Is was not resolved instead set to null.
### Steps to Reproduce
1. The existing test pipeline is a good example (https://github.com/Autodesk/shore/blob/567fcf51dd852d6449986a5de009e8dbebf09c8f/pkg/backend/spinnaker/backend_test.go#L834 ) where function findAndReplacePipelineNameWithFoundID (https://github.com/Autodesk/shore/blob/567fcf51dd852d6449986a5de009e8dbebf09c8f/pkg/backend/spinnaker/backend.go#L154) never gets called to resolve pipeline id for pipeline: "Finding Pipeline nested"
3.
4.
**Expected behavior:**
The pipeline stage pointing to an existing should have have pipeline id resolved.
**Actual behavior:**
The pipeline stage pointing to an existing should have have pipeline id resolved to null.
**Reproduces how often:**
100%
### Versions
### Additional Information
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.