Autodesk / Autodesk/revit-ifc

PR: invalid type and occurrence class

Open
#797 2 comments 0 reactions 0 assignees View on GitHub
problem
Dominant language
C#
Stars
637
Forks
225
PR merge metrics
No merged PRs in 30d

Description

### Problem Description

Our projects make heavy use of the `Export Type to IFC As` parameter (and `Type IFC Predefined Type`). I've been noticing that quite often, we will get scenarios where we might have a relating type of an IfcRoofType, and a related element of an IfcSlab. Or an IfcCurtainWallType and an IfcWindow, for example.

I haven't dug much into how to reproduce this, but it seems to only occur in those particular elements in IFC where IFC has specified use of aggregates (roofs, stairs, curtain walls).

Just to clarify, this bug is _not_ about IfcRelAggregates (e.g. aggregating a slab into a roof, which is OK). This bug is about IfcRelDefinesByType (e.g. IfcSlab being an IfcRoofType).

### Revit Version

2023.1.x

### IFC for Revit Addon Version

24.x.x

### Windows Version

11 22H2

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by reproducing IFC export for roofs, stairs, curtain walls, and windows in Revit 2023.1.x, then inspect the handling of IfcRelDefinesByType and compare the relating type with the related element. Done means those pairs receive valid matching IFC classes without changing valid IfcRelAggregates behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.