Autodesk / Autodesk/molecule-3d-for-react

React v15.5 update causes breaking changes

Open
#36 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
71
Forks
28
PR merge metrics
No merged PRs in 30d

Description

`PropTypes` must now be imported from the `prop-types` package, as mentioned in the React v15.5 announcement: https://reactjs.org/blog/2017/04/07/react-v15.5.0.html

From the announcement:
>Prop types are a feature for runtime validation of props during development. We’ve extracted the built-in prop types to a separate package to reflect the fact that not everybody uses them.
>In 15.5, instead of accessing PropTypes from the main React object, install the prop-types package and import them from there:

`React.PropTypes` is used here: https://github.com/Autodesk/molecule-3d-for-react/blob/ea30999599755f916a1db1d321b198e21348d1a6/src/components/molecule_3d.jsx#L53

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.