An in-range update of style-dictionary is breaking the build 🚨
- Dominant language
- JavaScript
- Stars
- 193
- Forks
- 112
- PR merge metrics
- No merged PRs in 30d
Description
## The devDependency [style-dictionary](https://github.com/amzn/style-dictionary) was updated from `2.4.0` to `2.5.0`.
🚨 [View failing branch](https://github.com/Autodesk/hig/compare/development...Autodesk:greenkeeper%2Fdefault%2Fstyle-dictionary-2.5.0).
This version is **covered** by your **current version range** and after updating it in your project **the build failed**.
style-dictionary is a devDependency of this project. It **might not break your production code or affect downstream projects**, but probably breaks your build or test tools, which may **prevent deploying or publishing**.
Status Details
- ✅ **ci/circleci: lockfile-update:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/Autodesk/hig/17847?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
- ✅ **ci/circleci: bootstrap:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/Autodesk/hig/17848?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
- ✅ **ci/circleci: package-build:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/Autodesk/hig/17849?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
- ✅ **ci/circleci: react-test:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/Autodesk/hig/17850?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
- ❌ **ci/circleci: visual-test:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/Autodesk/hig/17851?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
---
Release Notes for v2.5.0
- Migrated tests to Jest and added more testing especially for formats and templates
- Began deprecation path of templates. No power is being removed, you can still use templates in a format. It was confusing to people that we had both templates and formats, so this change simplifies the API without removing any features.
- Ability to control the generated comment at the top of formats and templates
- Added JSON5 support
- Added new format: json/nested
- Improved our error messaging and console output a lot. Rather than stop at 1 reference error, collect all the errors and show them at once so you don't have to fix one error, rebuild, repeat.
Thank you to all the contributors:
Commits
The new version differs by 30 commits.
eba4970Fixing security issues (#194)fa6ebebv2.5.0 (#191)41fedbaRemoving yarn.lock (#162)981b2ebFix security issue of dependency (#188)e9dabf7Hotfix: #185 (#186)f62a487Fix: #177 (#179)8d7af8dfixed problem with cover height + better padding for page (#176)233361cMerge pull request #130 from amzn/revert-129-developa8ce0efRevert "Develop master sync"5773478Merge pull request #129 from amzn/developf9880b3Sync master back into develop? (#128)149270d2.4.01b318d6Cleaning up the unit test7a01e09Fix: #111, resolveObject no longer mutates the original properties object861d392Fixing empty array/null
There are 30 commits in total.
See the full diff
FAQ and help
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
---
Your [Greenkeeper](https://greenkeeper.io) Bot :palm_tree:
Contributor guide
Research direction
Start with the Greenkeeper failing branch and inspect the CircleCI visual-test job, since the other listed checks passed. Compare the style-dictionary 2.4.0-to-2.5.0 update and determine what causes the visual tests to fail; done means the dependency update is compatible and all listed CI checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100