Autodesk / Autodesk/hig

Create exportable constants in the theme-data package

Open
#1,191 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
193
Forks
112
PR merge metrics
No merged PRs in 30d

Description

These should replace things like **constants.js** in the implementation of `Spacer` for #967.

When trying to implement a `Spacer` component that imports a list of available spacings (`['xxs', 'xs', ... 'xxl']`) from **@hig/theme-data**, the dependency caused the following crash for `Spacer`'s Enzyme tests:

screen shot 2018-09-11 at 2 36 21 pm

Investigate and address so that `Spacer` and other packages can import from a global constants file in **@hig/theme-data**

Contributor guide

Open the contributing guide

Research direction

Start by reading the existing constants.js used by Spacer and the @hig/theme-data package, then reproduce the crash in Spacer's Enzyme tests. The work is done when Spacer and other packages can import the shared constants from @hig/theme-data without causing the test failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.