AutoDarkMode / AutoDarkMode/Windows-Auto-Night-Mode

[Task] Add DI dependency injection for missing parts

Open
#1,222 0 comments 0 reactions 1 assignee Assigned to @ChenYiLins View on GitHub
area-internal area-winui3
Dominant language
C#
Stars
9.7k
Forks
308
Avg merge
2d 58m
Merged PRs (30d)
3

Description

> A long time ago, we used Template Studio to create the App project. Although its code seems very outdated to us now (as it hasn't been updated for a long time), the structure within the template was great! It built a solid foundation capable of supporting large-scale projects. However, while refactoring AutoDarkMode, in our pursuit of speed, we hardly followed the DI and MVVM patterns. That is why I am starting to modify things now—to make the project more robust, moving from "functional" to "well-crafted." Bringing these non-standard elements into alignment with best practices will be much better for the project's future development.

In this issue, it is used to track the part that should have been implemented by DI injection.

- [ ] App/Helpers/LanguageHelper [Change to LanguageService]
- [ ] App/Services/GeolocatorService

And find a better way to use IErrorService.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.