AssetMantle / AssetMantle/modules

test for nil IdentityID case panics

Open
#162 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
21
Forks
12
PR merge metrics
No merged PRs in 30d

Description

For equals method we should check if key comparing with is nil or not, else it will panic

https://github.com/AssetMantle/modules/blob/6b4ec6cd82bd80d119d5596f14f2647260dbc907/modules/identities/internal/key/key_test.go#L114-L117

https://github.com/AssetMantle/modules/blob/e76f0436f245a053ac1487215ebee4b6a8c24672/modules/identities/internal/key/key.go#L31-L38

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.