ArthurHub / ArthurHub/Android-Image-Cropper

v2.8.0 still calls clipRect(rect, Region.Op.XOR) on Android P

Open
#681 1 comment 8 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.4k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

SDK v2.8.0, CropOverlapView.java #620 - #628
You can see that it still call clipRect(rect, Region.Op.XOR) on Android P.
Unfortunately, only INTERSECT and DIFFERENCE are allowed on Android P+

canvas.save();
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
canvas.clipOutPath(mPath);
} else {
canvas.clipPath(mPath, Region.Op.INTERSECT);
}
canvas.clipRect(rect, Region.Op.XOR); <- will also be called on Android P
canvas.drawRect(left, top, right, bottom, mBackgroundPaint);
canvas.restore();

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.